Skip to content

Develop - #410

Closed
XPoet wants to merge 36 commits into
masterfrom
dev
Closed

XPoet wants to merge 36 commits into
masterfrom
dev

Conversation

@XPoet

@XPoet XPoet commented Oct 28, 2026

Copy link
Copy Markdown
Owner

No description provided.

markyangcc and others added 30 commits January 26, 2025 01:24
Switch diff code's highlights from bg highlights to text highlights
深浅色切换优化 / 修复加载闪屏
添加timeline功能
timeline功能。用法:(貌似markdown识别有点问题

{% timeline %}
  {% timenode 2024-04-15 %}
这是第一个时间点的内容。

测试包含**Markdown格式**的文本。

- 列表项1
- 列表项2

> 引用内容

![图片描述](图片链接)
  {% endtimenode %}
  
  {% timenode 2024-04-16 %}
这是第二个时间点的内容。
  {% endtimenode %}
  
  {% timenode 2024-04-17 %}
这是第三个时间点的内容。
  {% endtimenode %}
{% endtimeline %}
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T09:48:03.959020Z 6ae2dd4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@XPoet XPoet closed this Oct 28, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ae2dd4ee7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

registry-url: https://registry.npmjs.org/

- run: npm install
- run: npm ci

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Supply a committed lockfile before switching releases to npm ci

When a release is created, .github/workflows/release.yml now runs npm ci immediately after checkout/setup, but a repository-wide tracked-file search finds neither package-lock.json nor npm-shrinkwrap.json, and no preceding step generates one. npm's ci documentation explicitly states: “The project must have an existing package-lock.json or npm-shrinkwrap.json.” Consequently, the release job fails at installation and never reaches publication. Commit a matching lockfile or retain npm install.

Useful? React with 👍 / 👎.

Comment on lines +71 to +72
const post_word_count = page_type === 'post' ? keepWordCount(post.content) : 0
const post_min2read = page_type === 'post' ? keepMin2Read(post.content) : 0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the configuration guards for post word-count metadata

For sites with word counts or reading times disabled—including the supplied defaults—these calculations now run for every post, and the subsequent conditions render their results without checking either configuration switch. Nonempty posts therefore display both metrics despite post.word_count.word and post.word_count.min2read being false; keepMin2Read even returns at least 1 for empty content. Gate each calculation or rendered span on its corresponding option, preserving compatibility with the existing wordcount setting when migrating its name. This violates the configuration-default preservation requirement in AGENTS.md.

AGENTS.md reference: AGENTS.md:L17-L17

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants