Skip to content
This repository was archived by the owner on Jul 2, 2026. It is now read-only.

Add clang-tidy in clang images - #95

Merged
mathbunnyru merged 2 commits into
XRPLF:mainfrom
kuznetsss:Add_clang_tidy
Feb 12, 2026
Merged

mathbunnyru merged 2 commits into
XRPLF:mainfrom
kuznetsss:Add_clang_tidy

Conversation

@kuznetsss

Copy link
Copy Markdown
Contributor

Also add clang-21 images.

Comment thread .github/workflows/tools-rippled.yml Outdated

@mathbunnyru mathbunnyru left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You either need to provide separate LLVM_VERSION, or remove it

Comment thread docker/ubuntu/Dockerfile Outdated
@mathbunnyru
mathbunnyru merged commit 3c1da1d into XRPLF:main Feb 12, 2026
20 checks passed
@bthomee

bthomee commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

I propose to revert this change, since we don't need clang-tidy in all Ubuntu images. Instead, I'd like you to create a separate tools-rippled-clang-tidy image for this. We already have similar tools-rippled-clang-format, for instance.

@kuznetsss

kuznetsss commented Feb 12, 2026 •

Copy link
Copy Markdown
Contributor Author

@bthomee, but we need all the tools from a regular image to be able to generate compile_commangs.json. Creating a separate image will require to make another duplication of docker file. But having clang-tidy in each image doesn't do any harm except small size increase.

@kuznetsss
kuznetsss deleted the Add_clang_tidy branch February 13, 2026 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants