Drop python3.10 support and relax pandas dependencies - #111
Merged
Merged
Conversation
ClementPinard
force-pushed
the
fix/relax_pandas_version
branch
from
September 16, 2026 16:04
7adec21 to
d429359
Compare
ClementPinard
force-pushed
the
fix/relax_pandas_version
branch
2 times, most recently
from
September 16, 2026 16:19
bbae7ce to
75665aa
Compare
ClementPinard
force-pushed
the
fix/relax_pandas_version
branch
from
September 16, 2026 18:36
75665aa to
a7ab3db
Compare
ClementPinard
force-pushed
the
fix/relax_pandas_version
branch
from
September 16, 2026 18:40
a7ab3db to
349088b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
NacerKaciXXII
approved these changes
Sep 17, 2026
NacerKaciXXII
left a comment
NacerKaciXXII
left a comment
Collaborator
There was a problem hiding this comment.
@ClementPinard Thanks for the PR! I left a minor comment but otherwise everything lgtm so I'm approving. You can adress the comment then merge !
| "fiftyone>=1.0.0", | ||
| "boto3==1.26.83", | ||
| ] | ||
| plot-utils = [] |
Collaborator
There was a problem hiding this comment.
why did we remove matplotlib from this extra? Is it included somewhere else? If so we can just remove this extra altogether, else restore matplotlib here.
Collaborator
Author
There was a problem hiding this comment.
Ah you're right, it's weird it disappeared. I put it back in
It's an indirect dev dependency but not a package dependency, so it makes sense to keep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Describe your changes
Python 3.10 is approaching end of life : https://devguide.python.org/versions/
Also, now that pandas 3 is out, we might as well make sure we are compatible with instead of pinning version
EDIT: Got some errors when upgrading packages. SO the PR is now heavier than before.
Issue number if applicable
Checklist before requesting a review
Github actions will check that these tasks were performed but it will reduce friction if you deal with them beforhand