chore: Move Deployable Files Into public/ - #34
Merged
Merged
Conversation
index.html, favicon.ico, img/ and js/ are the only files served to lndecode.com; test/, tools/ and the repository configuration are not. Grouping the served files under one directory makes the deploy a sync of a single tree rather than a list of paths to include. Nothing inside the page changes: every reference in index.html is relative, so the four items move together and it still opens over file://. The paths that pointed at the old locations are updated -- the eslint file globs, the test loader and dead-code checks, the secp256k1 vendoring output, and the CI vendor-integrity diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Xtrimmer
changed the title
Xtrimmer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The repository root mixes what the site serves with what only development needs.
index.html,favicon.ico,img/andjs/go to lndecode.com;test/,tools/,eslint.config.js,package.jsonand the workflow do not. A deploy has to name the four served paths and keep that list correct as the repo changes, and reading the root gives no clue which is which.Solution
Move the four served items under
public/, so the deploy is a sync of one tree rather than a list of paths.Every reference inside
index.htmlis relative, so the page is unchanged and still opens overfile://.Paths that pointed at the old locations are updated: the eslint file globs, the test loader and the dead-code checks, the output path in
tools/vendor-secp256k1.js, and the vendor-integrity diff in CI. The README now sayspublic/is the deploy root.539 tests pass and eslint is clean.