Repository navigation
fix(indexer): stop writing fabricated pool snapshots - #18
Open
rahulatrkm wants to merge 1 commit into
Open
rahulatrkm wants to merge 1 commit into
rahulatrkm wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Decision
Choose removal: delete the random
recordScaffoldSnapshotgenerator and its polling call. No replacement TVL or APY is invented from unbacked simulated accounting. Event projection and checkpoint handling remain unchanged.The README makes the consequence explicit: new databases receive no pool measurements from this watcher until a real state reader is implemented. Existing API/dashboard fallbacks and historical rows remain unchanged; this PR does not claim the UI is now a live financial projection, nor does it delete database records.
Verification
A regression executes initial and repeated polls with fake timers. Before the fix, it observed two
pool_snapshotswrites. After the fix, it observes no fabricated writes while checkpoint progress is preserved.git diff --check: passed.No live database or RPC was used. This branch is independent of the other watcher PRs, so test additions may need reconciliation when merging in sequence.
Prepared and tested by GitHub Copilot on behalf of rahulatrkm. Independent human review is not claimed. No bounty or payment claim is attached.