Repository navigation
ci(release): release with release-please and an approval step - #2
Conversation
A merged release PR bumps plugin.json and both versions in .github/plugin/marketplace.json, then a job in the release environment creates the tag and the GitHub release. Commit hygiene checks PR titles so release-please can read them.
|
The release flow looks right: the version bumps hit the right files, release detection is strict, re-runs are safe and the actions are pinned to SHAs. Two things before merging: 1. There's no approval step until the environment is set up. The 2. The attribution check misses a Markdown link. |
|
Correction to point 1: in iac-bootstrap the |
Releases stop being manual. This adapts the zenrows-python-sdk release setup to a plugin with nothing to build or publish.
How a release works
fix(...)orfeat(...)PR makes release-please openchore: release X.Y.Z. It bumpsplugin.jsonversionand both versions in.github/plugin/marketplace.json.releasejob in thereleaseenvironment, which creates the tagvX.Y.Zand the GitHub release with generated notes.ci,docs,choreand the other hidden types never open a release PR, so this PR releases nothing.Differences from python-sdk
release-type: simple, no build job, no PyPI steps.ci.yml.workflow_dispatchre-run: it only existed to republish to PyPI.skip-changelog: true, as in python-sdk.CHANGELOG.mdstays as history; release notes live on the GitHub release.First release
The tag
v0.1.0(on main's head) has no GitHub release. release-please falls back to the tag, so only commits after it count: the nextfix(...)gives 0.1.1.Before merging (repo settings, admin)
release, deployment branchmainonly.ZenRows/prod-approversteam needs write access for CODEOWNERS.Checks
extra-fileson the same path are merged into one update; a missing tag release falls back to thev0.1.0tag.