Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this bug while formally verifying a function that did
sha256(abi.encode(...)).The sha256, ripemd160 and modexp precompile models size their z3 function sorts with arg_size, which is in bytes, but the input bitvector is arg_size * 8 bits. So any call with symbolic input fails with Z3Exception: Sort mismatch.
The fix is * 8 on the input sorts, and on modexp's modulus_size output sort, the same way sha3_data already does it.
Added Precompile.t.sol with a symbolic test for each precompile. They error on main and pass with this change.
The fix is similar to #591 but also fixes ripemd and modexp