fix: Fixing the index page#942
Conversation
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request converts absolute links to relative links in the documentation and replaces a markdown code block with HTML pre/code tags, accompanied by a CSS adjustment to left-align preformatted text. The review feedback recommends appending trailing slashes to the relative URLs to avoid unnecessary 301 redirects and points out an absolute path for the logo image that might fail to load if hosted on a subpath.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <a href="server" class="btn btn-primary">Server Guide <i class="fa-solid fa-arrow-right"></i></a> | ||
| <a href="client" class="btn btn-secondary">Client Guide <i class="fa-solid fa-arrow-right"></i></a> |
There was a problem hiding this comment.
When using relative paths for clean URLs in static sites, it is best practice to include a trailing slash (e.g., server/ instead of server). This prevents the web server from performing an unnecessary 301 redirect to append the trailing slash when resolving the directory.
Additionally, please note that the logo path on line 12 (logo="/images/a2a-java-sdk.png") still uses an absolute path. If this site is hosted on a subpath, the logo image will fail to load. Consider updating it to a relative path as well.
| <a href="server" class="btn btn-primary">Server Guide <i class="fa-solid fa-arrow-right"></i></a> | |
| <a href="client" class="btn btn-secondary">Client Guide <i class="fa-solid fa-arrow-right"></i></a> | |
| <a href="server/" class="btn btn-primary">Server Guide <i class="fa-solid fa-arrow-right"></i></a> | |
| <a href="client/" class="btn btn-secondary">Client Guide <i class="fa-solid fa-arrow-right"></i></a> |
| </dependency></code></pre> | ||
|
|
||
| <p>See the <a href="/server">Server Guide</a> and <a href="/client">Client Guide</a> for full setup instructions, or browse <a href="/community">Community Articles</a> for tutorials and examples.</p> | ||
| <p>See the <a href="server">Server Guide</a> and <a href="client">Client Guide</a> for full setup instructions, or browse <a href="community">Community Articles</a> for tutorials and examples.</p> |
There was a problem hiding this comment.
For consistency and to avoid unnecessary 301 redirects, use trailing slashes for these relative links as well.
| <p>See the <a href="server">Server Guide</a> and <a href="client">Client Guide</a> for full setup instructions, or browse <a href="community">Community Articles</a> for tutorials and examples.</p> | |
| <p>See the <a href="server/">Server Guide</a> and <a href="client/">Client Guide</a> for full setup instructions, or browse <a href="community/">Community Articles</a> for tutorials and examples.</p> |
1 participant
No description provided.