Repository navigation
Conversation
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com> Signed-off-by: Polina Cherkasova <polina.c@live.com>
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com> Signed-off-by: Polina Cherkasova <polina.c@live.com>
polina-c
changed the title
17 of 23 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the conformance test suites for direct JSON and express agents. It adds explanatory comments regarding surface creation assumptions and updates various test cases (such as response parsing and streaming tests) to explicitly prepend a createSurface action before any component or data model updates are performed, reflecting the requirement that renderers reject updates to non-existent surfaces. Since there are no review comments, I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React on #3283