Skip to content

refactor(dart/core): rename _GraphBound to ComponentGraphBound - #3328

Merged
nan-yu merged 4 commits into
mainfrom
refactor/dart-core-component-graph-bound
Oct 20, 2026
Merged

nan-yu merged 4 commits into
mainfrom
refactor/dart-core-component-graph-bound

Conversation

@nan-yu

@nan-yu nan-yu commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Renames _GraphBound in dart/a2ui_core to ComponentGraphBound and extracts it to dart/a2ui_core/lib/src/validation/component_graph_bound.dart so all three SDKs use the same class and file naming:

Test Plan

  • dart analyze (No issues found!)
  • dart test test/component_graph_bound_test.dart (All tests passed!)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the codebase by extracting the private _GraphBound class from component_model.dart into a new, separate file component_graph_bound.dart as an @internal class named ComponentGraphBound. The review feedback suggests retaining explicit type annotations for loop variables when iterating over collections in the newly created file.

Comment thread dart/a2ui_core/lib/src/core/component_graph_bound.dart Outdated
@nan-yu
nan-yu force-pushed the refactor/dart-core-component-graph-bound branch from f122eb3 to a2b69ce Compare October 19, 2026 23:05
@nan-yu
nan-yu requested a review from polina-c October 19, 2026 23:41
@nan-yu
nan-yu added this pull request to stack #3343 October 20, 2026 18:39
@nan-yu
nan-yu merged commit 10b83f1 into main Oct 20, 2026
50 checks passed
@nan-yu
nan-yu deleted the refactor/dart-core-component-graph-bound branch October 20, 2026 18:50
@github-project-automation github-project-automation Bot moved this from Todo to Done in A2UI Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants