Repository navigation
refactor(dart/core): rename _GraphBound to ComponentGraphBound - #3328
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase by extracting the private _GraphBound class from component_model.dart into a new, separate file component_graph_bound.dart as an @internal class named ComponentGraphBound. The review feedback suggests retaining explicit type annotations for loop variables when iterating over collections in the newly created file.
nan-yu
force-pushed
the
refactor/dart-core-component-graph-bound
branch
from
October 19, 2026 23:05
f122eb3 to
a2b69ce
Compare
polina-c
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames
_GraphBoundindart/a2ui_coretoComponentGraphBoundand extracts it todart/a2ui_core/lib/src/validation/component_graph_bound.dartso all three SDKs use the same class and file naming:ComponentGraphBoundincomponent_graph_bound.dart(component_graph_bound_test.dart)ComponentGraphBoundincomponent_graph_bound.py(test_component_graph_bound.py)ComponentGraphBoundincomponent-graph-bound.ts(component-graph-bound.test.ts)Test Plan
dart analyze(No issues found!)dart test test/component_graph_bound_test.dart(All tests passed!)