Repository navigation
Conversation
Metal is no longer single precision only: device 'mps' with precision 'float64' is the emulated double precision of abTEM/abTEM#620. Replace the bullet that said it is refused with a section on it, and describe the SlowFFTSizeWarning advice for both precisions. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
device="mps"withprecision="float64"is emulated double precision (double-float kernels on the GPU, float64 data on the host). Replace the install page's bullet saying that combination is refused with a "Double precision" subsection: what runs on the GPU, what falls back to the CPU, thetorch.mps.compile_shaderrequirement, thetorch.emulate-float64key and the benchmark script.SlowFFTSizeWarningadvice, for single and emulated double precision.The page links to
benchmarks/benchmark_metal_float64.py, which exists once abTEM/abTEM#620 is merged, so this should merge after it. The example in the new section was run against #620 on an Apple M2. The doc site was not built.🤖 Generated with Claude Code