Repository navigation
fix: make clean script cross-platform - #27
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🔵 Needs a closer look
The nonexistent Autoprefixer version prevents dependency installation.
0 open findings
What changed in this PR
Makes the clean script cross-platform using Node’s filesystem API.
Changes:
- Replaces
rm -rfwithfs.rmSync. - Accidentally changes Autoprefixer to a nonexistent version.
| File | Description |
|---|---|
package.json |
Updates cleanup command and Autoprefixer dependency. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea6441d1b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@types/react-dom": "^19.0.0", | ||
| "@vitejs/plugin-react": "^6.1.1", | ||
| "autoprefixer": "^10.4.21", | ||
| "autoprefixer": "^4.10.21", |
There was a problem hiding this comment.
^4.10.21 drops the major-version digit from the previously declared release: Autoprefixer publishes 10.4.21, but no 4.10.21 release satisfies this range. The root CI workflow runs npm install before linting, building, and testing, so dependency installation will fail with an ETARGET error and prevent every root CI run from reaching those checks.
Useful? React with 👍 / 👎.
Problem
The
cleannpm script usesrm -rf, which is not available in the default Windows command shell used by npm on Windows. This makes a normal development task fail on Windows.Change
Replace the shell-specific command with Node's
node:fsrmSync, preserving the same cleanup targets (dist/andserver.js) and making the script work across supported operating systems.Validation
The command uses Node APIs already available in the project runtime. CI should verify the repository's typecheck, build, and smoke test; this PR does not change application runtime behavior.