Repository navigation
feat: add LiveObjects #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
owenpearson
wants to merge
9
commits into
integration/v4
Choose a base branch
from
feature/liveobjects
base: integration/v4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2669df5
test: derive the LiveObjects unit specifications
owenpearson 9d84e7d
test: derive the LiveObjects integration specifications
owenpearson ee2397d
objects: add the LiveObjects data model and objects sync
owenpearson e2600f3
objects: sync and publish objects over the channel
owenpearson 16f8842
objects: add the path-based LiveObjects API
owenpearson 44afda6
objects: batch several writes into one message
owenpearson ef954b5
docs: record the LiveObjects derivation
owenpearson 11e7451
docs: add LiveObjects to the README
owenpearson 20760c3
objects: fail sync waits on an inactive channel and skip bad messages
owenpearson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| """LiveObjects: shared, conflict-free data structures stored on a realtime channel. | ||
|
|
||
| The public names are re-exported from :mod:`ably.pubsub.server`; the modules here | ||
| hold the implementation behind them, and the internal classes the specification | ||
| names (``ObjectsPool``, ``InternalLiveMap``, ``InternalLiveCounter`` and the wire | ||
| types). | ||
| """ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Update the integration-tier count.
This command runs
rest/integration,realtime/integration, andobjects/integration. The explanation at Line 1011 still says “the two integration tiers.” Change it to “the three integration tiers” so the guidance matches the command.🧰 Tools
🪛 SkillSpector (2.11.2)
[warning] 825: [TM3] Unsafe Defaults: Tool defaults are unsafe or overly permissive (e.g. disabled TLS verification, no authentication, world-writable permissions). Unsafe defaults widen the attack surface.
Remediation: Override unsafe defaults with secure settings (verify=True, auth required, restrictive permissions). Review and harden all tool configurations.
(Tool Misuse (TM3))
🤖 Prompt for AI Agents