Repository navigation
Deprecate releasing a realtime channel that isn't detached (RTS4b) - #460
Merged
Merged
Conversation
Spec 6.3.0 deletes RTS4a, under which Channels#release detaches the channel before removing it, and replaces it with RTS4e, under which release raises error 90011 unless the channel is initialized, detached or failed. RTS4b lets SDKs that already implement the old behaviour keep it until their next major version, provided they log a deprecation warning when it takes effect. Channels in the initialized, detached or failed state are now removed immediately (RTS4d) rather than via detach. Previously a failed channel could never be released, since detaching it fails. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the deprecation half of the
Channels#releasechange in spec 6.3.0 (ably/specification#557).Spec 6.3.0 replaces RTS4a (release detaches the channel first) with RTS4c–e (release raises error 90011 unless the channel is initialized, detached or failed). RTS4b lets SDKs that already implement RTS4a keep it until their next major version, provided they log a deprecation warning.
Realtime::Channels#releasenow logs a deprecation warning when called on a channel that is not initialized, detached or failed, then keeps the old detach-then-release behaviour.The breaking change for 2.0 is in #461. Reference ably-js PRs: ably/ably-pubsub-js#2322 (deprecation) and ably/ably-pubsub-js#2323 (next major).
🤖 Generated with Claude Code