Clarify that RSH3h isn't meant to re-initialise the device#494
Open
lawrence-forooghian wants to merge 1 commit into
Open
Clarify that RSH3h isn't meant to re-initialise the device#494lawrence-forooghian wants to merge 1 commit into
lawrence-forooghian wants to merge 1 commit into
Conversation
RSH8a says "The LocalDevice is initialised when first required" but it doesn't say "only when first required"; Marat pointed out that RSH3h could arguably be interpreted as meaning "perform this initialisation process again". (I'm on the fence and think that "initialisation" implies a one-off thing, but no harm in clarifying.)
maratal
approved these changes
Jun 18, 2026
maratal
left a comment
maratal
left a comment
Collaborator
There was a problem hiding this comment.
RSH8a says "The LocalDevice is initialised when first required" but it doesn't say "only when first required"; Marat pointed out that RSH3h could arguably be interpreted as meaning "perform this initialisation process again". (I'm on the fence and think that "initialisation" implies a one-off thing, but no harm in clarifying.)
I'm a bit confused by this wording, all I was trying to say is that the device can be (and actually is for identified clients) initialized elsewhere (not upon state machine init) and thus automatically violating RSH3h. So loosing this requirement would make things easier for the current implementations. The change itself is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSH8a says "The LocalDevice is initialised when first required" but it doesn't say "only when first required"; Marat pointed out that RSH3h could arguably be interpreted as meaning "perform this initialisation process again". (I'm on the fence and think that "initialisation" implies a one-off thing, but no harm in clarifying.)