fix: add missing PRODUCT and LISTING values to IssueCategory enum - #954
Merged
abuzuhri merged 1 commit intoSep 14, 2026
Merged
Conversation
|
Contributor
|
@abuzuhri is it possible to get this one pushed through? its causing issues, although i appreciate this was a non documented change by amazon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IssueCategorywas missing two of the values defined in Amazon's Listings Items API model. This PR adds them:PRODUCTLISTINGSource of truth:
listingsItems_2021-08-01.jsoninamzn/selling-partner-api-models, where theIssue.categoriesproperty lists these values alongside the ones already present.Problem
Issue.Categories(Source/FikaAmazonAPI/AmazonSpApiSDK/Models/ListingsItems/Issue.cs) is typed asList<IssueCategory>and the enum is deserialized with Newtonsoft'sStringEnumConverter. When Amazon returns an issue categorized asPRODUCTorLISTING, deserialization fails and the exception propagates out of the Listings Items call — so a single unrecognized category value breaks the entire response, not just that one field.Changes
Source/FikaAmazonAPI/AmazonSpApiSDK/Models/ListingsItems/IssueCategoryEnum.cs: addedPRODUCT = 9andLISTING = 10with the matching[EnumMember(Value = ...)]attributes, following the existing formatting and XML-doc style of the file.Compatibility
Purely additive. The new members are appended after the existing ones, so no existing numeric value changes and no current behavior is affected. Callers that
switchoverIssueCategorymay want to handle the two new cases.