Repository navigation
Conversation
Every image branch of accel-sim/Dockerfile becomes dockerfiles/<tag>.Dockerfile, with 13.2-minimal taken from accel-sim/Dockerfile#12 (the branch of that name held a 12.8 Dockerfile). The two never-published 2025 images (18.04/11.0, 22.04/11.7) are left behind. 12.8-minimal gains the AWS CLI and boto3. docker-images.yml builds only the Dockerfiles a change touches: a modified file always, an added one only if its tag is not on ghcr yet. PRs build without pushing; the merge to dev rebuilds from pc02's cache and pushes. Builds run on tgrogers-raid with DOCKER_HOST pointing at tgrogers-pc02's daemon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n's sm_70 targets It was never published and 13.2-minimal supersedes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retires
accel-sim/Dockerfile. Its image branches move here, one file per image, and are built by a new workflow.What moves
dockerfiles/<tag>.Dockerfile, built asghcr.io/accel-sim/accel-sim-framework:<tag>.Ubuntu-24.04-cuda-13.2-minimalcomes from Ubuntu 24.04 CUDA 13.2.1 minimal Dockerfile#12. The branch of that name held a 12.8 Dockerfile (FROM ...cuda:12.8.0).Ubuntu-24.04-cuda-12.8-minimalgains the AWS CLI and boto3, so CI's image can also run AWS Batch jobs.Ubuntu-18.04-cuda-11.0andUbuntu-22.04-cuda-11.7, from 2025.Ubuntu-24.04-cuda-13.1.1-minimal, superseded by 13.2. CUDA 13 cannot build gpu-app-collection'ssm_70targets:nvcc fatal: Unsupported gpu architecture 'compute_70'.When images build
.github/workflows/docker-images.ymlbuilds only the Dockerfiles a change touches. The rules are in.github/scripts/docker-plan.sh, which logs a build/skip reason for each image to the job summary:dev: builds again and pushes. pc02 has the PR build's layers cached, so the push is the only real work.workflow_dispatch: builds the tags you name, with an optionalno_cache.accel-sim/accel-sim-framework.Builds run on
tgrogers-raid, which has no docker daemon. The runner account's docker CLI and buildx drive tgrogers-pc02's daemon overDOCKER_HOST=ssh://tgrogers-pc02. The same setup published the current12.8-minimalfromaccel-sim/Dockerfile(run 41171899169).Expected on this PR
One full build,
Ubuntu-24.04-cuda-13.2-minimal, which is not on ghcr yet. The other 7 images are skipped. 13.2 will likely hit the samecompute_70error until accel-sim/gpu-app-collection#91 adds CUDA 13 support.Before merge
Give this repo Write on the ghcr package
accel-sim-framework, under Package settings → Manage Actions access. Otherwise the post-merge push is denied.Testing
docker-plan.shwas checked against real history:docker buildx build --call=checkwithdockerfiles/as the context.🤖 Generated with Claude Code