Repository navigation
Compatibility: Fix NO_ARGS run - #579
Open
AndrewVu23 wants to merge 1 commit into
Open
AndrewVu23 wants to merge 1 commit into
AndrewVu23 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small compatibility fix so that we can read both
NO_ARGSpre-2.0 traces &None2.0.1 traces.Motivation / root cause
NO_ARGS. I used the old traces to run some experiments and found this problem. Although the new runs are stored inNoneand don't have any issues if the traces are made after 2.0, I just thought this would be useful for people who are reusing traces from pre 2.0.NO_ARGSis still in the .md of mlperf & AccelWattch.Compatibility / backward compatibility
Simulation output folders post-2.x.x under
Nonearen't remapped, so they will have to either re-run or rename them.