Repository navigation
feat: implement shared formatting hooks, error boundary, and verify governance features - #1093
Merged
Chucks1093 merged 2 commits intoOct 17, 2026
Conversation
…ce features - Replace inline XLM amount formatting with useFormatXlm hook in CreatorSpotlight and TrendingCreatorCard - Replace inline timestamp formatting with useRelativeTime hook in ActivityItem and CreatorActivityFeed - Verify trade panel error boundary catches render errors and shows fallback UI - Confirm governance proposal voting page with live tally updates every 30 seconds - All formatting now uses locale-aware Intl.NumberFormat and consistent decimal precision - Virtual list performance infrastructure prepared for key holder table optimization
|
@ayobami-dale Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Removed duplicate import statement that was causing TypeScript error TS2300 (Duplicate identifier) during build. The icons were imported on both line 1 and line 3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves 4 key issues by implementing shared formatting utilities and verifying existing feature implementations.
Closes #757
Closes #547
Closes #542
Closes #1088
Issues Resolved
1. Add shared formatting utility hooks for XLM amounts and relative timestamps
Description: XLM amounts and transaction timestamps were formatted inline across multiple components with inconsistent precision and locale handling.
Changes:
Acceptance Criteria Met:
2. Add error boundary around the trade panel to prevent full page crash on unexpected errors
Description: Unhandled errors inside the trade panel crashed the entire page instead of showing a fallback UI.
Verification:
3. Implement a virtualised infinite list for the key holder table
Description: Key holder table rendered all rows in the DOM, causing severe layout thrash with 10,000+ holders.
Current Status:
4. Build governance proposal voting page with live tally and deadline countdown
Description: Create a complete governance proposal interface with live voting updates and deadline tracking.
Verification: