Skip to content

Add integration test for re-initialization attempt reverting without modifying contract state #584

Closed

Description

@Chucks1093

Summary

Calling the initialize function on an already-initialized contract should revert. An integration test should confirm the revert occurs, the error code is correct, and none of the existing protocol config values were overwritten by the failed call.

Scope

  • Initialize the contract with admin A and fee bps 300
  • Attempt to re-initialize with admin B and fee bps 500
  • Assert the second call reverts with the already-initialized error code
  • Assert admin and fee bps remain as set in the first initialization

Acceptance Criteria

  • Re-initialization reverts with already-initialized error code
  • Admin unchanged after failed re-init
  • Fee bps unchanged after failed re-init
  • Fee recipient unchanged after failed re-init

ETA: 12 hours


Coordinate on Telegram

Activity

  1. MoscowDev commented on Jul 23, 2026

    @MoscowDev

    I’d love to take this issue on. I’ve worked on production-ready applications and collaborated extensively through GitHub workflows. I’ll dig into the current setup, implement a solid and reliable fix, and deliver a well-tested PR. My focus is on clean, maintainable code and fast, dependable delivery.

  2. jaynomyaro commented on Jul 23, 2026

    @jaynomyaro
    Contributor

    Hi! I’m a full-stack developer with a strong blockchain background, and I’m confident I can resolve this issue quickly and effectively. I’ll deliver a clean, reliable solution with immediate attention to detail, ensuring it’s completed as soon as possible. Please assign it to me—I’m ready to get started right away.

  3. olaayoade91-byte commented on Jul 23, 2026

    @olaayoade91-byte

    hello i would like to work on this please assign me

  4. Menjay7 commented on Jul 23, 2026

    @Menjay7

    Hi! I came across this issue and would love to work on it. I have experience with similar tasks and I'm confident I can investigate, implement a clean solution, and thoroughly test it before submitting a PR. If the issue is still open, I would appreciate it if you could assign it to me. I’ll prioritize this immediately and ensure a reliable solution is delivered as soon as possible. Thank you!

  5. Truphile commented on Jul 23, 2026

    @Truphile

    Hi! I'd like to work on this.

    My first step will be to understand the current implementation and any architectural constraints that influenced it. I'll then implement the requested behavior with minimal impact on existing interfaces, ensuring the change is isolated, testable, and consistent with the project's established patterns. I'll extend the test suite to cover functional behavior, failure modes, and regression scenarios before opening a PR.

  6. guptakumarranjeet150 commented on Sep 12, 2026

    @guptakumarranjeet150

    Hi maintainers,

    I would like to resolve this issue. Here is my proposed execution plan:

    • Implementation: Implement Add integration test for re-initialization attempt reverting without modifying contract state with explicit require_auth checks, clean storage layouts, and robust Soroban contract logic.
    • Testing & Verification: Add comprehensive unit tests verifying both happy-path invocations and unauthorized revert scenarios.
    • Delivery: Ready to ship a thoroughly tested PR within 12–24 hours with passing CI.

    Happy to pick this up today—please assign to me!

  7. shobhamerabacha-star commented on Sep 13, 2026

    @shobhamerabacha-star

    Hey team,

    I would like to resolve this issue. Here is my proposed execution plan:

    • Implementation: Implement Add integration test for re-initialization attempt reverting without modifying contract state with explicit require_auth checks, clean storage layouts, and robust Soroban contract logic.
    • Testing & Verification: Add comprehensive unit tests verifying both happy-path invocations and unauthorized revert scenarios.
    • Delivery: Ready to ship a thoroughly tested PR within 12–24 hours with passing CI.

    Happy to pick this up today—please assign to me!

  8. Ranjeet2063 commented on Oct 3, 2026

    @Ranjeet2063

    Hi,

    I have experience with similar implementations and would like to take this on.

    Technical outline:

    1. Audit storage layout and state invariants ensuring strict auth guards.
    2. Implement deterministic state transitions with safe checked arithmetic.
    3. Add hermetic unit and regression tests covering authorized, unauthorized, and boundary edge cases.
    4. Profile instruction and CPU/gas limits under Soroban host environment.

    Could you please assign this issue to me? Looking forward to delivering a clean PR.

  9. Kenlachy commented on Oct 17, 2026

    @Kenlachy

    @Kenlachy has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi. Please, I want to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Kenlachy to this issue.

  10. Nexus00031 commented on Oct 17, 2026

    @Nexus00031

    @Nexus00031 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi! I’d like to work on this issue.

    I’ve worked on similar tasks across different stacks and I’m comfortable contributing within existing architectures and project conventions. I’ll make sure the implementation is clean, tested, and aligned with the requirements outlined in the issue.

    Thanks!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Nexus00031 to this issue.

  11. Chigybillionz commented on Oct 17, 2026

    @Chigybillionz

    Hello, I would like to take this issue.

    I have gone through the details and I am interested in contributing a fix. I will work on the implementation and open a PR once it is ready for review.

    Thanks!

  12. Real-Ola commented on Oct 17, 2026

    @Real-Ola

    @Real-Ola has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I would love to fix this issue. Kindly assign it to me

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Real-Ola to this issue.

  13. hmhidey111-collab commented on Oct 17, 2026

    @hmhidey111-collab

    @hmhidey111-collab has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello, I'd like to pick this issue up.

    I'm a software engineer with strong experience in JavaScript and building scalable web applications. I'm comfortable working across the stack, writing clean, maintainable code, and collaborating in open source environments.

    I've reviewed the issue and I'm confident I can implement a solid solution while following the project's conventions.

    I'd love the opportunity to work on this — please consider assigning it to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @hmhidey111-collab to this issue.

  14. dynamicgram11-cmyk commented on Oct 17, 2026

    @dynamicgram11-cmyk

    @dynamicgram11-cmyk has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I’ve reviewed the issue and have a clear path to a solid fix. I would love to take this on, feel free to assign it to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @dynamicgram11-cmyk to this issue.

  15. 5 remaining items

  16. deborahogunjinmi592-byte commented on Oct 17, 2026

    @deborahogunjinmi592-byte

    @deborahogunjinmi592-byte has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer
    I'm interested in working on the issue
    Could you please assign it to me?

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @deborahogunjinmi592-byte to this issue.

  17. iyanukid2008-pixel commented on Oct 17, 2026

    @iyanukid2008-pixel

    @iyanukid2008-pixel has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I’ve gone through the issue in detail and have a clear understanding of the expected outcome. I’d like to take this on and approach the implementation with a focus on correctness, maintainability, and consistency with the current codebase.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @iyanukid2008-pixel to this issue.

  18. solrektme-dev commented on Oct 17, 2026

    @solrektme-dev

    @solrektme-dev has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I’d love to help solve this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @solrektme-dev to this issue.

  19. damilare0813 commented on Oct 17, 2026

    @damilare0813

    @damilare0813 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello, I'd like to work on this. I have experience with Rust/Soroban and I've worked on similar tests before. I can start now and open PR within 2 days. Here is my GitHub: [your link]"

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @damilare0813 to this issue.

  20. Jerry-Tekh commented on Oct 17, 2026

    @Jerry-Tekh

    @Jerry-Tekh has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    please let me work on this issue . i will get it done correctly .

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Jerry-Tekh to this issue.

  21. Ahmad12developer commented on Oct 17, 2026

    @Ahmad12developer

    @Ahmad12developer has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer
    I like to work on this issue with basic understanding am having for the project

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ahmad12developer to this issue.

  22. Jessicaayegh commented on Oct 17, 2026

    @Jessicaayegh
    Contributor

    @Jessicaayegh has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer! I’d love to work on this issue if it’s still available. I have a good understanding of the requirements and would be happy to implement the solution. Thanks for considering my request!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Jessicaayegh to this issue.

  23. arraahmon244-pixel commented on Oct 17, 2026

    @arraahmon244-pixel

    @arraahmon244-pixel has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Assign let me fix

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @arraahmon244-pixel to this issue.

  24. Peolite001 commented on Oct 17, 2026

    @Peolite001
    Contributor

    @Peolite001 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I would love to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Peolite001 to this issue.

  25. drips-wave commented on Oct 17, 2026

    @drips-wave

    Congratulations, @Peolite001! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @Peolite001: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  26. grantfox-oss commented on Oct 18, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @Peolite001's PR #1064 was approved and merged by @Chucks1093.

    🏆 @Peolite001: You earned 45 FoxPoints for this contribution! Your current tier: Specialist (3,090 total points). Track your full progress on GrantFox.

    👏 Great work, @Peolite001! Keep contributing to accesslayerorg.

  27. drips-wave commented on Oct 18, 2026

    @drips-wave

    This issue has been completed by @Peolite001 as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @Peolite001: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions