Repository navigation
feat(creator-keys): add max_slippage_bps parameter to buy and sell functions - #1065
Open
Samuel-21-eng wants to merge 4 commits into
Open
Samuel-21-eng wants to merge 4 commits into
Samuel-21-eng wants to merge 4 commits into
Conversation
…ll tests passing successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full Description:
1 - Extend buy and sell contract functions (
buy_with_slippage,buy_key_with_slippage,buy_keys_with_slippage,buy_key_with_ref_and_slip, andsell_key_with_slippage) with an optionalmax_slippage_bpsparameter.2 - Compute price impact (
actual_bps) against the current bonding curve state before execution (reference_pricevs
execution_price_after_fees).3 - Account for fees correctly in impact computation (evaluated after protocol fee deduction).
4 - Revert with
ContractError::SlippageExceeded(emitting event with actual vs max basis points) when priceimpact exceeds
max_slippage_bps.5 - Safely skip the check (opt-in) when
max_slippage_bpsisNoneorSome(0).6 - Add comprehensive unit and integration tests covering all acceptance criteria in
creator-keys/tests/slippage_protection.rs.closes #975