Repository navigation
feat(creator-keys): add atomic bundle purchase for multiple keys (#1057) - #1083
Merged
Merged
Conversation
…esslayerorg#1057) Add bundle_buy and get_bundle_quote so a buyer can purchase several creator keys in one transaction that succeeds or reverts as a unit. - bundle_buy(buyer, items: [{key_id, amount, max_price}]) runs every item through the shared buy logic; any failing item, including one that exceeds its max_price, reverts the whole bundle - Emit BundleExecuted with a per-item breakdown (key_id, amount, price_paid) and the total cost - get_bundle_quote(items) returns estimated cost and price impact (bps) per item, plus the total - Reject bundles with more than 10 items (BundleSizeExceeded) - Add BundleItemUnfilled so a partial fill caused by a supply or wallet cap reverts the bundle instead of succeeding short Refactor buy_keys_with_ref_and_slip into a public wrapper that calls require_auth and an internal buy_keys_core that returns the keys bought and total price. Behavior of existing buy paths is unchanged. Tests: bundle_buy.rs covers full success, event breakdown, revert on slippage / unregistered key / supply cap, quote vs execution accuracy, price impact, and the 10-item limit. Closes accesslayerorg#1057
|
@KingDavid9999 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bundle_buy and get_bundle_quote so a buyer can purchase several
creator keys in one transaction that succeeds or reverts as a unit.
item through the shared buy logic; any failing item, including one
that exceeds its max_price, reverts the whole bundle
price_paid) and the total cost
(bps) per item, plus the total
wallet cap reverts the bundle instead of succeeding short
Refactor buy_keys_with_ref_and_slip into a public wrapper that calls
require_auth and an internal buy_keys_core that returns the keys
bought and total price. Behavior of existing buy paths is unchanged.
Tests: bundle_buy.rs covers full success, event breakdown, revert on
slippage / unregistered key / supply cap, quote vs execution
accuracy, price impact, and the 10-item limit.
Closes #1057