Repository navigation
Port the cal-table gains/D-terms split to the mixpol branch - #333
Merged
Merged
Conversation
rohandahale
marked this pull request as ready for review
September 21, 2026 12:26
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-backend-mixpol #333 +/- ##
======================================================
+ Coverage 48.79% 49.17% +0.38%
======================================================
Files 54 54
Lines 27132 27241 +109
Branches 4631 4662 +31
======================================================
+ Hits 13238 13397 +159
+ Misses 12400 12324 -76
- Partials 1494 1520 +26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
achael
approved these changes
Sep 24, 2026
achael
left a comment
Owner
There was a problem hiding this comment.
looks good, sorry for the delay in approving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the cal-table gains/D-terms split (#331, merged to
dev-backendas357a8b9) ontodev-backend-mixpol, so the mixed-pol branch stops carrying the welded D-term row layout that #331 removed.Cherry-pick of the #331 merge commit, plus one cleanup. No new cal-table work.
Resolutions
Two files conflicted, both because the mixpol copy differs from
dev-backendfor reasons unrelated to this PR:const_def.py: Caltable: split gains and D-terms into two tables #331 addedDTDTERMto__all__. This branch has no__all__(it is adev-backend-only addition), so the block is dropped rather than introduced. Verified this costs no exports: with no__all__the star import inehtim/__init__.pyre-exports everything, andeh.DTDTERM,eh.DTDTERM_CIRC,eh.DTDTERM_LINandeh.upgrade_caltableall resolve.plotting/interactive.py: comment-only. The mixpol copy of the D-term panel TODO lacked the "in MixPol Phase 1" phrase, so only the removed side differed. Both branches now carry the same comment.#331 removed the five Array/Obsdata legacy-upgrade tests from
test_mixedpol.py, which left_legacy_circ_datatable()with no callers (it is dead ondev-backendtoday for the same reason). This branch drops the helper._LEGACY_DTPOL_CIRCstill has a live user and stays.