[pull] trunk from SeleniumHQ:trunk - #902
Merged
Merged
Conversation
* [rb] fix silent hang on oversized WebSocket frames websocket-ruby drops frames larger than WebSocket.max_frame_size (20MB default) and keeps returning nil, so the listener spun forever and the process appeared to hang (e.g. large CDP data: URL payloads under request interception). Raise the limit to 100MB for our connections (lazily, and only when the user has not already set a larger value, so non-DevTools users and custom configs are unaffected), and surface an undecodable frame as a logged error that stops the listener instead of hanging silently. Fixes #17264 * address qodo comments * address qodo re-review - make close idempotent instead of short-circuiting after the listener initiated shutdown, and guard against self-join - fail fast in send_cmd when the connection is closing instead of waiting for the full response timeout - make the dropped-frame error log actionable and accurate for non-size decode errors - tag WebSocketConnection as @api private and document why the frame size limit is process-global and not restored on close * raise IOError from send_cmd fail-fast to keep closed-connection error class --------- Co-authored-by: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )