Fix: remove _menu from scaffold attribute blacklist (fixes #484)

[swashbuck]

Fixes #484

Fix

Removed _menu from ATTRIBUTE_BLACKLIST in app/modules/scaffold/index.js.

The blacklist is applied globally to all schemas before rendering forms. _menu was included to suppress the internal content-object property of the same name, but the name collision also hid any theme schema group named _menu (e.g. the Menu colour group in adapt-contrib-vanilla). The _menu content-object attribute is already excluded from theme forms by context — it is not present in theme schemas — so the blacklist entry is unnecessary and only causes harm.

Testing

1. Install adapt-contrib-vanilla v9.37.1 (or any theme with a _menu group in schema/theme.schema.json).
2. Open the theme editor for a course.
3. Confirm the Menu fieldset is visible and all colour picker fields render correctly.
4. Open the content-object editor and confirm no _menu field appears there.

Posted via collaboration with Claude Code

[taylortom]

This blacklist was specifically added for the _menu and _theme props on the config schema which are never set directly.

We have a basic mechanism for hiding fields via the schema (not a recursive check, top-level only as it stands - this needs updating). If we remove the blacklisted items, we need to make sure the schemas are updated to match (although we need to be mindful that AATs with older versions of the schemas won't pick up the changes until FW/plugins are updated).

We ideally need to update all schemas for the blacklisted props to avoid these issues going forward.