Repository navigation
chore: modernize runtime and browser dependencies - #26
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's GuideConfigurationRaise the declared Node runtime and CI matrix together so support policy and tested versions agree.
Pin Tabler Icons Webfont at 3.49.0 and document why later releases are incompatible with the current vendored asset strategy.
DocumentationUpdate the documented server minimum to Node.js 22+.
Refresh the generated code map and graph artifacts for the current repository state.
TestsAdd checks that the package engine requirement and CI matrix enforce the same supported Node releases.
Lock files and vendored codeRefresh the shipped Marked and DOMPurify browser bundles and their dependency lock data.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="package.json" line_range="9" />
<code_context>
},
"engines": {
- "node": ">=18"
+ "node": ">=22"
}
},
</code_context>
<issue_to_address>
**EOL Node 23 remains allowed**
When the project is run or installed under end-of-life Node 23, `>=22` accepts Node 23, and the regression test requires that broad range, so an end-of-life runtime remains declared as supported despite the stated LTS-only policy.
Declare only the supported LTS major ranges and update the regression test to enforce those ranges.
Also at `tests/workflow-security.test.cjs:38`.
</issue_to_address>
### Comment 2
<location path=".github/workflows/ci.yml" line_range="32" />
<code_context>
fail-fast: false
matrix:
- node: ["20", "22"]
+ node: ["22", "24"]
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
</code_context>
<issue_to_address>
**Documented CI runtimes are outdated**
When readers use the documented CI coverage to assess runtime compatibility, pRODUCTION_SECURITY.md says the Redis Lua tests run on Node 20 and 22, but the CI matrix runs them on Node 22 and 24, so readers get inaccurate runtime coverage information.
Update PRODUCTION_SECURITY.md to say the Redis Lua tests run on Node 22 and 24.
</issue_to_address>| "main": "server.cjs", | ||
| "engines": { | ||
| "node": ">=18" | ||
| "node": ">=22" |
There was a problem hiding this comment.
⚪ Low · EOL Node 23 remains allowed
When the project is run or installed under end-of-life Node 23, >=22 accepts Node 23, and the regression test requires that broad range, so an end-of-life runtime remains declared as supported despite the stated LTS-only policy.
Declare only the supported LTS major ranges and update the regression test to enforce those ranges.
Also at tests/workflow-security.test.cjs:38.
Prompt for AI agents
In `package.json` at line 9:
**EOL Node 23 remains allowed**
When the project is run or installed under end-of-life Node 23, `>=22` accepts Node 23, and the regression test requires that broad range, so an end-of-life runtime remains declared as supported despite the stated LTS-only policy.
Declare only the supported LTS major ranges and update the regression test to enforce those ranges.
Also at `tests/workflow-security.test.cjs:38`.| fail-fast: false | ||
| matrix: | ||
| node: ["20", "22"] | ||
| node: ["22", "24"] |
There was a problem hiding this comment.
⚪ Low · Documented CI runtimes are outdated
When readers use the documented CI coverage to assess runtime compatibility, pRODUCTION_SECURITY.md says the Redis Lua tests run on Node 20 and 22, but the CI matrix runs them on Node 22 and 24, so readers get inaccurate runtime coverage information.
Update PRODUCTION_SECURITY.md to say the Redis Lua tests run on Node 22 and 24.
Prompt for AI agents
In `.github/workflows/ci.yml` at line 32:
**Documented CI runtimes are outdated**
When readers use the documented CI coverage to assess runtime compatibility, pRODUCTION_SECURITY.md says the Redis Lua tests run on Node 20 and 22, but the CI matrix runs them on Node 22 and 24, so readers get inaccurate runtime coverage information.
Update PRODUCTION_SECURITY.md to say the Redis Lua tests run on Node 22 and 24.
Summary
Verification
Summary by Sourcery
Modernize the supported runtime and browser dependencies while enforcing consistent runtime policy and vendor asset compatibility.
Enhancements:
Build:
Documentation:
Tests:
Chores: