Skip to content

chore: modernize runtime and browser dependencies - #26

Merged
adiarora06 merged 2 commits into
mainfrom
codex/modernize-node-runtime
Nov 17, 2026
Merged

adiarora06 merged 2 commits into
mainfrom
codex/modernize-node-runtime

Conversation

@adiarora06

@adiarora06 adiarora06 commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • raise the supported runtime from end-of-life Node releases to Node 22+ and test Node 22/24 in CI
  • update Marked and DOMPurify, then regenerate the browser assets that the deployed app actually serves
  • pin Tabler 3.49.0 because later releases split the webfont into dozens of files; the sync guard now documents that boundary
  • add a regression check that keeps the declared runtime and CI matrix aligned

Verification

  • npm audit (0 vulnerabilities)
  • npm test (all suites passed)
  • npm run check:vendor
  • npm run test:workflow

Summary by Sourcery

Modernize the supported runtime and browser dependencies while enforcing consistent runtime policy and vendor asset compatibility.

Enhancements:

  • Raise the supported Node.js runtime to 22+ and align CI coverage with Node 22 and 24.
  • Refresh the vendored Marked and DOMPurify browser assets and pin Tabler icons to preserve the supported webfont bundle.
  • Add validation that keeps the declared Node.js runtime and CI matrix synchronized.

Build:

  • Update browser dependency versions and regenerate the committed vendor assets.

Documentation:

  • Update the documented server runtime requirement to Node.js 22+.

Tests:

  • Extend workflow checks to enforce the supported runtime policy and CI matrix.

Chores:

  • Regenerate Graphify repository analysis artifacts.

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tok Ready Ready Preview Nov 17, 2026 7:11pm UTC

@sourcery-ai

sourcery-ai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Configuration

Raise the declared Node runtime and CI matrix together so support policy and tested versions agree.

  • .github/workflows/ci.yml L32
  • package.json L9, L41-43

Pin Tabler Icons Webfont at 3.49.0 and document why later releases are incompatible with the current vendored asset strategy.

  • scripts/sync-vendor.cjs L7-9

Documentation

Update the documented server minimum to Node.js 22+.

  • README.md L22

Refresh the generated code map and graph artifacts for the current repository state.

  • graphify-out/.graphify_analysis.json L690-710, L797-813, L1132-1150 (+28 small edits)
  • graphify-out/GRAPH_REPORT.md L253-264, L289-313, L332-360 (+16 small edits)
  • graphify-out/graph.html L66-71
  • graphify-out/graph.json L7542-10729, L25426-25996, L27052-27633 (+341 small edits)
  • graphify-out/manifest.json L103-108, L448-455 (+5 small edits)
  • graphify-out/.graphify_labels.json L1 (removed lines)
  • graphify-out/.graphify_labels.json.sig L1 (removed lines)

Tests

Add checks that the package engine requirement and CI matrix enforce the same supported Node releases.

  • tests/workflow-security.test.cjs L5-6, L36-42

Lock files and vendored code

Refresh the shipped Marked and DOMPurify browser bundles and their dependency lock data.

  • outputs/vendor/dompurify/purify.min.js L1-6
  • outputs/vendor/marked/marked.umd.js L2, L13-69, L74-87
  • package-lock.json L15-20, L56-58, L66-68

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 2 issues

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="package.json" line_range="9" />
<code_context>
       },
       "engines": {
-        "node": ">=18"
+        "node": ">=22"
       }
     },
</code_context>
<issue_to_address>
**EOL Node 23 remains allowed**

When the project is run or installed under end-of-life Node 23, `>=22` accepts Node 23, and the regression test requires that broad range, so an end-of-life runtime remains declared as supported despite the stated LTS-only policy.

Declare only the supported LTS major ranges and update the regression test to enforce those ranges.

Also at `tests/workflow-security.test.cjs:38`.
</issue_to_address>

### Comment 2
<location path=".github/workflows/ci.yml" line_range="32" />
<code_context>
       fail-fast: false
       matrix:
-        node: ["20", "22"]
+        node: ["22", "24"]
     steps:
       - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
</code_context>
<issue_to_address>
**Documented CI runtimes are outdated**

When readers use the documented CI coverage to assess runtime compatibility, pRODUCTION_SECURITY.md says the Redis Lua tests run on Node 20 and 22, but the CI matrix runs them on Node 22 and 24, so readers get inaccurate runtime coverage information.

Update PRODUCTION_SECURITY.md to say the Redis Lua tests run on Node 22 and 24.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread package.json
"main": "server.cjs",
"engines": {
"node": ">=18"
"node": ">=22"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Low · EOL Node 23 remains allowed

When the project is run or installed under end-of-life Node 23, >=22 accepts Node 23, and the regression test requires that broad range, so an end-of-life runtime remains declared as supported despite the stated LTS-only policy.

Declare only the supported LTS major ranges and update the regression test to enforce those ranges.

Also at tests/workflow-security.test.cjs:38.

Prompt for AI agents
In `package.json` at line 9:

**EOL Node 23 remains allowed**

When the project is run or installed under end-of-life Node 23, `>=22` accepts Node 23, and the regression test requires that broad range, so an end-of-life runtime remains declared as supported despite the stated LTS-only policy.

Declare only the supported LTS major ranges and update the regression test to enforce those ranges.

Also at `tests/workflow-security.test.cjs:38`.

Comment thread .github/workflows/ci.yml
fail-fast: false
matrix:
node: ["20", "22"]
node: ["22", "24"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Low · Documented CI runtimes are outdated

When readers use the documented CI coverage to assess runtime compatibility, pRODUCTION_SECURITY.md says the Redis Lua tests run on Node 20 and 22, but the CI matrix runs them on Node 22 and 24, so readers get inaccurate runtime coverage information.

Update PRODUCTION_SECURITY.md to say the Redis Lua tests run on Node 22 and 24.

Prompt for AI agents
In `.github/workflows/ci.yml` at line 32:

**Documented CI runtimes are outdated**

When readers use the documented CI coverage to assess runtime compatibility, pRODUCTION_SECURITY.md says the Redis Lua tests run on Node 20 and 22, but the CI matrix runs them on Node 22 and 24, so readers get inaccurate runtime coverage information.

Update PRODUCTION_SECURITY.md to say the Redis Lua tests run on Node 22 and 24.

@adiarora06
adiarora06 merged commit 5cb26eb into main Nov 17, 2026
10 of 11 checks passed
@adiarora06
adiarora06 deleted the codex/modernize-node-runtime branch November 17, 2026 19:13

This branch was successfully deployed

1 active deployment
Preview — 1c4bc85d Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant