Repository navigation
fix(otel): pass the logger provider to enable() for browser-instrumentation 0.11 - #105
Merged
Merged
Conversation
…tation 0.11
browser-instrumentation 0.11.0 dropped setLoggerProvider and registerInstrumentations no longer accepts its instrumentations. The docs example and the contract fixture now call enable({ loggerProvider }), and the pinned fixture moves to 0.11.0 so both CI jobs check that setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly OTel job started failing Nov 11 since
@opentelemetry/browser-instrumentation0.11.0 droppedsetLoggerProviderand the provider now goes toenable(), which broke the docs example too.Switched the example and the fixture to
enable({ loggerProvider })and bumped the pinned versions to match.