Repository navigation
Conversation
adityareddy-dev
left a comment
Owner
There was a problem hiding this comment.
Can you wrap the two new paragraphs to match the rest of CONTRIBUTING.md? In the first, I'd use "checks ... and compiles ..." and drop "(no browser required)", since the last paragraph already says it runs without a browser.
The earlier paragraph still calls test:pack and test:vite-app "the two checks" that use the published package. Can you add test:otel there too? It also installs the tarball.
Author
|
Thanks for the feedback!
Pushed the changes in the latest commit. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #100
Summary of Changes
npm run test:otelto the primary checks list inCONTRIBUTING.md.fixtures/otel, as well as compiling TypeScript code blocks fromdocs/opentelemetry.mdthat start with a// src/...path comment.npm run test:otel,--fresh, and--tarball.--fresh), and prints the retained temporary copy's path on failure.git diff --check.