Repository navigation
Conversation
adityareddy-dev
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #99
Summary
replaceTable()inscripts/size-table.mjsjoined the replacement table (formatted with LF byformatTable()) directly into the surrounding text, causing mixed line endings whenREADME.mduses CRLF.Changes
replaceTable()to detect if the existing<!-- size:start -->...<!-- size:end -->block uses CRLF and convert the replacement table to match, while keeping surrounding text byte-for-byte.packages/core/test/size.test.ts, covered both LF and CRLF replacements, verified surrounding text remains unchanged, and confirmedproblems()accepts the rewritten table.Verification
false(no mixed LF).node --import ./packages/core/test/ts-imports.ts --test packages/core/test/size.test.ts(4/4 passing)npm run test:unit(674/674 passing)npm run typecheck(passed with no errors)git diff --check(clean)