Skip to content

Problem when generating search points in parallelgridsearch for ndim = 1 case #9

Description

@CY-Zhang

I found out that when generating search points in parallelgridsearch (modules/parallelstuff.py line 343), if ndim = 1, the create_hammersley_samples function could return values outside [0,1) range when initializing x0s, which then leads to inf or nan when the values are feed to erfinv(-1+2*x0s). Here is a screenshot of the part that generates x0s:

image

These inf or nan points would result in inf or nan points in res, then the sorting of res would fail and an empty array would be returned.

image

Maybe we need to modify the dim=1 case in create_hammersley_samples function, or maybe we can simply cut the inf and nan entrees in x0s.

Another minor issue is in modules/bayes_optimization.py, Line 134-142, module 'copy' is called but it was not imported. We only have 'from copy import deepcopy', but not copy itself.

image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions