Remove iOS target and implementation - #136
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (44)
💤 Files with no reviewable changes (27)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details
|
| Layer / File(s) | Summary |
|---|---|
Build and shared platform cleanup composeApp/build.gradle.kts, gradle/libs.versions.toml, composeApp/src/commonMain/... |
The iOS targets, dependencies, platform object, iOS icon, and iOS-specific documentation references are removed or updated. |
iOS implementation removal
| Layer / File(s) | Summary |
|---|---|
iOS app and platform implementations composeApp/src/iosMain/kotlin/com/inspiredandroid/oak/... |
The iOS application entry point, platform services, controllers, permission handlers, and UI stubs are deleted. |
iOS data and feature integrations composeApp/src/iosMain/kotlin/com/inspiredandroid/oak/data/..., .../email/..., .../inference/..., .../notifications/..., .../sms/... |
iOS persistence, email, inference, notification, and SMS implementations are deleted. |
Project surface and documentation
| Layer / File(s) | Summary |
|---|---|
Project surface and documentation updates .github/..., .run/..., README.md, docs/features/*, docs/index.md |
The issue template, run configuration, README, and feature documentation no longer list iOS as a supported platform. |
Priority: ➖ Normal
Estimated code review effort: 4 (Complex) | ~60 minutes
Change: Other
Merge Risk: ⚪ Minimal · up to e3827
The iOS removal is internally consistent across the remaining supported targets and project surfaces, with no actionable merge-blocking risk identified.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 6 files. (11 skipped: … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly and concisely describes the main change: removal of the iOS target and its implementation. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 6 files. (11 skipped: 11 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
- Create stacked PR
- Commit on current branch
🛠️ Fix failing CI checks 💡
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
remove-ios
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
iOS paths fade from the build
Native stubs rest, quiet and still
Docs align with targets anew
Android and desktop carry through
Web and WASM remain in view
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
./gradlew :composeApp:compileKotlinDesktop --no-daemon --console=plainjavac, so an Android assemble task could not be run here.Historical changelog entries remain unchanged.
Summary by CodeRabbit