Repository navigation
Fix varpeek parsing for hyphenated paths - #172
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Owner
|
Merged in 1a07743. I adjusted the test a bit and preserved your authorship. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
varpeek_addsearched for-across the entire varspec. For the documented single-line form<varname>@<path>:<line>, a hyphen in the file path can be mistaken for the optional range delimiter. The resulting line-end parse is zero, so the requested variable is never registered and no peek record is emitted.Search for the range delimiter only after the final
:and add a synthetic PHP fixture whose filename contains a hyphen.Validation:
bash -n tests/test_varpeek_hyphen.shandgit diff --checkpass. The full C build, PHP/ptrace integration test, and ShellCheck were not run locally: this Windows/MSYS host lacks the Linux ptrace environment and thecc,php, andmaketools. The new test is included by the existingmake testwildcard and traces only its own synthetic PHP child in the supported Linux CI environment.