Repository navigation
Fix UPGRADING/NEWS: so_linger is not applied to unix sockets - #3
Merged
Merged
Conversation
Only so_rcvbuf and so_sndbuf were extended to unix and unix datagram sockets; so_linger remains TCP-only, as agreed in phpGH-23584 review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UPGRADING and NEWS entries for 87b2d5d say so_linger, so_rcvbuf and so_sndbuf are now applied to unix sockets, but main/streams/xp_socket.c still only reads so_linger for TCP (
PHP_STREAM_XPORT_IS_TCP), as agreed in the phpGH-23584 review. Drop so_linger from both entries so the docs match the code.