Repository navigation
build(deps): bump gpui and gpui_platform to 347f171 together - #158
Conversation
The two crates come from the same zed commit and must move together; the separate Dependabot PRs (#138, #139) each bumped one and failed to build. gpui renamed ScrollWheelEvent to ScrollEvent and on_scroll_wheel to on_scroll. The integration smoke now checks for the project name anywhere in the README's first line, which became an HTML heading in #157.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 07252d71-83eb-4d52-8438-494887f624f1) |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
Self-review at 722a8f4: lockfile, three gpui renames in src/viewer.rs and one smoke assertion. No behavior change in our code; validation in the PR body. |
![revuto-review[bot]](https://avatars.githubusercontent.com/in/4488771?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is an auto review done by revuto.
Revuto completed the review and found no evidence-backed concerns.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 896c2763-aae8-47f7-ac05-9a9d4a837f6f) |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
There was a problem hiding this comment.
This is an auto review done by revuto.
Revuto completed the review and found no evidence-backed concerns.
Replaces #138 and #139, which each bumped one of the two crates from the same zed commit and failed to build.
gpuiandgpui_platformmove to 347f171 together;taffyfollows to 0.15.ScrollWheelEvent->ScrollEvent,on_scroll_wheel->on_scroll(three uses in the viewer).# agent-workspace-linuxin the README's first line; docs: restructure the README and list each backend's packages #157 made that line an HTML heading. It now checks for the project name.Validation: fmt, clippy -D warnings, 256 tests in both TMPDIR modes, runtime isolation smoke (x11), terminal lifecycle and integration smoke pass. The viewer, launched inside a hidden KWin workspace, renders the same as with the old gpui.
Note
Medium Risk
Touches the UI stack (gpui, layout/taffy, macOS bindings) and viewer input forwarding; behavior should be equivalent but regressions are most likely in scrolling and rendering.
Overview
Bumps the gpui / gpui_platform git dependency (and related zed crates) to commit
347f171, with lockfile fallout including taffy0.15.0, deduplicated cocoa versions, and oo7 pinned to a zed fork revision.Dependabot now groups
gpuiandgpui_platformin one weekly Cargo PR so they upgrade together from the same zed commit.The viewer adapts to gpui API renames:
ScrollWheelEvent→ScrollEventandon_scroll_wheel→on_scrollfor workspace scroll forwarding.Integration smoke no longer expects
# agent-workspace-linuxin the README first line; it asserts the page containsagent-workspace-linuxafter the heading markup change.Reviewed by Cursor Bugbot for commit b985872. Configure here.