Repository navigation
test(installer): give the installer update tests a 60 second limit - #56
Merged
Merged
Conversation
The tests run the installer, which waits for Traefik for several seconds. One of them took 6.2 seconds on a loaded CI runner and failed against the default limit of 5 seconds, in pull requests that did not touch the installer. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The installer update tests run the installer, which waits for Traefik for several seconds. One test took 6.2 seconds on a loaded CI runner and failed against the default 5 second limit. It failed in pull requests that did not touch the installer. The file already uses a 60 second limit for its other slow tests; this sets it for the whole file.
Test plan
biome checkpasses.🤖 Generated with Claude Code