Repository navigation
[docs] update OpenShell guide - #1302
Merged
Merged
Conversation
Signed-off-by: Art Berger <art.berger@solo.io>
Signed-off-by: Art Berger <art.berger@solo.io>
Deploying agentproxy with
|
| Latest commit: |
aa70267
|
| Status: | ⚡️ Build in progress... |
danehans
self-requested a review
October 16, 2026 23:21
danehans
approved these changes
Oct 16, 2026
danehans
left a comment
danehans
left a comment
Collaborator
There was a problem hiding this comment.
I have 2 non-blocking review comments:
- Make the crash-loop diagnosis conditional. Line 259 says a timeout plus crash loop means the issuer is unreachable. Those symptoms have other causes. Suggest checking logs first, then applying the OIDC fix when discovery errors confirm it. The pod-deletion workaround is valid for a stalled StatefulSet rollout, but its explanation should describe that specific condition. Kubernetes documents this recovery case.
- Clarify when manual login is needed. Line 302 suggests logging in again after token expiry. OpenShell v0.1.3 already attempts automatic refresh. Better: “If token refresh fails or reauthentication is required, run openshell gateway login production.” Refresh implementation.
Signed-off-by: Art Berger <art.berger@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1282.