Repository navigation
[Automated] Draft docs (agentgateway): health: only consider server-side grpc errors as unhealthy - #1306
Open
github-actions[bot] wants to merge 1 commit into
Open
[Automated] Draft docs (agentgateway): health: only consider server-side grpc errors as unhealthy#1306github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…ide grpc errors as unhealthy Signed-off-by: GitHub Action <action@github.com>
Deploying agentproxy with
|
| Latest commit: |
500f548
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6552ebe9.agentproxy.pages.dev |
| Branch Preview URL: | https://pr-tracker-draft-agentgatewa-jx8h.agentproxy.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentgateway/agentgateway#3897 — health: only consider server-side grpc errors as unhealthy
Docs versions:
standalone/main,kubernetes/mainNo code-path rule covers 1 touched file(s). The planner could route these only by identifier search, so the candidate pages may miss what they changed, including in the other mode:
crates/agentgateway/src/http/health.rsWhat changes for users: The default health classifier no longer treats client-side gRPC statuses, such as
INVALID_ARGUMENT, as unhealthy. Server-side gRPC failures, such asINTERNAL, still lower health and can trigger default failover eviction.What the docs now say: The standalone and Kubernetes virtual-model failover pages now say that default eviction covers server-side gRPC failures, not every non-zero gRPC status.
Not verified: No cluster or local agentgateway run; the configuration is unrun.
How
agentgateway-3897was drafted, and what was not verifiedPlan, and what changed it
health.rsunrouted file showed a health-classification change, and the main virtual-model pages carried the stale failover wording.Why a documentation change is necessary
The pull request changes the default health classifier from any non-zero gRPC status to only server-side gRPC failures. The standalone virtual-model page said that non-zero gRPC statuses were unhealthy, which became wrong. The Kubernetes virtual-model page documented default failover eviction for 5xx responses and connection failures, and needed the server-side gRPC failure case added for the same runtime behavior.
What changed on disk
content/docs/standalone/main/documentation/llm/virtual-models.md: Replaced the non-zero gRPC status wording with server-side gRPC failures in the failover health table andunhealthyExpressionbullet.content/docs/kubernetes/main/documentation/llm/models/virtual.md: Added server-side gRPC failures to the default failover eviction description.How to verify this change
Cannot be verified from the diff alone. The dossier includes unit-test assertions for status
13as unhealthy and status3as healthy, but it does not include a runnable documentation setup that produces those provider responses.What was not verified
How the pages were chosen (triage report)
Draft a documentation change
agentgateway/agentgateway#3897 — health: only consider server-side grpc errors as unhealthy
agentgateway/websitecrates/agentgateway/src/http/health.rsRelease notes
This pull request also adds its release-note entries:
content/docs/kubernetes/main/release-notes/release-notes.md: health: only consider server-side grpc errors as unhealthy (fix, under LLM)content/docs/standalone/main/release-notes/release-notes.md: health: only consider server-side grpc errors as unhealthy (fix, under LLM)Draft branch:
pr-tracker-draft-agentgateway-3897