Repository navigation
[Automated] Draft docs (agentgateway): allow mcp auth with jwt validation - #1308
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…tion Signed-off-by: GitHub Action <action@github.com>
Deploying agentproxy with
|
| Latest commit: |
fdb0598
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e17213c9.agentproxy.pages.dev |
| Branch Preview URL: | https://pr-tracker-draft-agentgatewa-wqg9.agentproxy.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentgateway/agentgateway#3936 — allow mcp auth with jwt validation
Docs versions:
standalone/main,kubernetes/mainWhat changes for users: MCP authentication can now run after route-level JWT authentication when
preserveToken: truekeeps the token available. In strict mode, MCP authentication rejects the request only when a previous Gateway or Route JWT policy removed the token; in permissive mode, that missing-token case is skipped.What the docs now say: The Kubernetes JWT setup page and the standalone JWT authentication page now say that
preserveTokenalso lets MCP authentication validate the same token after route-level JWT authentication.Not verified: No cluster or standalone binary run; the configuration is unrun.
How
agentgateway-3936was drafted, and what was not verifiedPlan, and what changed it
preserveTokenrequirement where the JWT pages already describe downstream policies that read a validated token.changed-functions.mdshow the behavior is specifically MCP authentication after route-level JWT validation, while the target JWT pages already ownpreserveToken.Why a documentation change is necessary
The pull request changes
apply_token_validationso MCP authentication no longer rejects every request that already has JWT claims. It rejects only when a previous JWT policy validated and removed the token, and the tests showpreserveToken: truelets strict MCP authentication validate a token whose audiences include both the route JWT audience and the MCP audience. The JWT docs already tell readers to setpreserveTokenfor token exchange, but they did not name MCP authentication as another policy that reads the same token from the request.What changed on disk
assets/agw-docs/pages/security/jwt-setup.md— Adds the MCP authentication use case to thepreserveTokenfield row for Kubernetes main docs, behind a main-only version gate.content/docs/standalone/main/documentation/configuration/security/jwt-authn.md— Adds the same MCP authentication use case to the standalone main JWT authentication page.How to verify this change
routes[].policies.jwtAuth.preserveToken: trueandroutes[].policies.mcpAuthenticationon the same route.initializerequest with a valid bearer token whoseaudclaim includes both the route JWT audience and the MCP authentication audience. The request returns200.preserveTokenfrom the route JWT policy and repeat the request. In strict mode, the request returns401with the messageMCP backend authentication configured but the token was removed by a Gateway or Route level JWT policy; set preserveToken on that policy.What was not verified
The configuration was not applied to a cluster, and no standalone agentgateway binary was run. No example output blocks were changed.
How the pages were chosen (triage report)
Draft a documentation change
agentgateway/agentgateway#3936 — allow mcp auth with jwt validation
agentgateway/websitepreserveToken: truewe can still run MCP backend authentication. Only reject when the token is not available.Release notes
This pull request also adds its release-note entries:
content/docs/standalone/main/release-notes/release-notes.md: allow mcp auth with jwt validation (fix, under MCP)Release notes kept out of a tree. Check that each change really does not reach the trees named here:
kubernetes/main, because the draft edited no page there. If the change also reaches that tree, add the note there.Draft branch:
pr-tracker-draft-agentgateway-3936Important
The test suite has not run on this pull request. It was opened by
github-actions[bot], and GitHub does not start workflows for pull requests opened with the repository's own token. Doc tests, link checking and the static checks are held asaction_requireduntil somebody presses Approve and run on the Checks tab. Cloudflare Pages and DCO are GitHub Apps rather than Actions, so those two do run on their own.Please approve the checks before reviewing the content: an absence of failures here means the tests have not run, not that they passed.