Skip to content

fix(opa): reject unhashable mapper decisions #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imran-siddique merged 1 commit into from
Oct 2, 2026
Merged

fix(opa): reject unhashable mapper decisions #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/agentrust_telemetry/adapters/opa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,13 @@ def opa_decision_log(
raise ValueError("OPA decision log requires a non-empty decision_id")
mapper = result_mapper or _boolean_decision
decision = mapper(decision_log.get("result"))
if decision not in {"allow", "deny", "challenge", "not_applicable", "error"}:
if not isinstance(decision, str) or decision not in {
"allow",
"deny",
"challenge",
"not_applicable",
"error",
}:
raise ValueError(f"OPA result mapper returned unsupported decision: {decision!r}")
labels = decision_log.get("labels", {})
if not isinstance(labels, dict):
Expand Down
16 changes: 11 additions & 5 deletions tests/test_adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,11 +175,17 @@ def test_opa_requires_non_empty_string_decision_id(self):
"OPA decision log requires a non-empty decision_id")

def test_opa_rejects_unsupported_mapper_decision(self):
with self.assertRaises(ValueError) as caught:
self.opa_event({"decision_id": "d-1", "result": {}},
result_mapper=lambda value: "permit")
self.assertEqual(str(caught.exception),
"OPA result mapper returned unsupported decision: 'permit'")
for decision in ("permit", {}, []):
with self.subTest(decision=decision):
with self.assertRaises(ValueError) as caught:
self.opa_event(
{"decision_id": "d-1", "result": {}},
result_mapper=lambda value, decision=decision: decision,
)
self.assertEqual(
str(caught.exception),
f"OPA result mapper returned unsupported decision: {decision!r}",
)

def test_opa_requires_object_labels(self):
for labels in ([], None, "version=1.8.0"):
Expand Down
Loading