Repository navigation
fix(release): require CI and test the final npm tarball - #79
imran-siddique merged 1 commit into
Conversation
Reuse CI before release builds and verify the exact packed npm consumer surface before artifact handoff, per agentrust-io/.github#54. Signed-off-by: Srinivasa Dinakar <dinakarjs@gmail.com>
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
imran-siddique
left a comment
There was a problem hiding this comment.
Reviewed ebfb212 against the two approved gaps in agentrust-io/.github#54. The reusable CI matrix is a prerequisite for build, so failed/cancelled/skipped validation blocks both publishers. The npm smoke check installs the final tarball outside the checkout, checks public imports and declarations, exercises valid/invalid schema controls and golden event construction, and leaves publication using that same uploaded artifact.
Validation: all 3 release-safeguard tests passed locally. Inspected CI job 112185144861: 44 TypeScript tests and all 4 installed-tarball checks passed. The Python 3.10–3.13 matrix and workflow lint are green. No release workflow was dispatched.
Release builds currently run independently of the CI matrix, and npm validation checks the source tree before packing. Reuse the full CI workflow before building, and install the final npm tarball into a fresh consumer directory before uploading that same artifact for publication. Failed, cancelled or skipped validation blocks both publishers.
The installed-package checks cover public imports and module origin, package identity/version and declarations, all shared valid/invalid conformance fixtures, and golden event construction. CI exercises this packed consumer path on pull requests too. Both registry publishers and release assets retain their existing artifact handoff and protected environments.
Scope: approved ruling in agentrust-io/.github#54. @imran-siddique, please review.
Validation:
Other Python versions and Node 20 require GitHub CI. No release dispatch, publication or environment/reviewer setting changes were performed. Local tarballs were created solely to validate the proposed packaging check.
Signed-off-by: Srinivasa Dinakar dinakarjs@gmail.com