Repository navigation
ci(conformance): grade TR-ANC-002 against a pinned anchor corpus - #550
Closed
astrogilda wants to merge 2 commits into
Closed
astrogilda wants to merge 2 commits into
astrogilda wants to merge 2 commits into
Conversation
Add a workflow that downloads an external registry anchor corpus at a commit pinned in conformance/interop/trace-anchor/pin.json, checks every file against its SHA-256, and answers each case with this suite's own TR-ANC-002. The corpus is read as data and nothing from it is installed. The job fails on a disagreement that pin.json does not list. At main it agrees on 19 of 27 cases; the 8 listed disagreements are the ones spec/registry-anchor-v1.md and the open entry-binding change address. Signed-off-by: Sankalp Gilda <23521054+astrogilda@users.noreply.github.com>
Add a short section to the TR-ANC module page saying what the Anchor corpus workflow checks, when it fails, and how its pin moves. Signed-off-by: Sankalp Gilda <23521054+astrogilda@users.noreply.github.com>
astrogilda
requested review from
a team,
lywinged and
rajnisht7
as code owners
October 16, 2026 22:29
Contributor
|
❔ Contributor Check: UNKNOWN
Automated check by AgenTrust Contributor Check. |
github-actions
Bot
added
the
needs-review:UNKNOWN
Member
|
@astrogilda take your own offer: vendor the 27 cases byte-identical under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
@lywinged,
.github/workflows/anchor-corpus.ymlgrades a 27-case registry anchor corpus with TR-ANC-002, checking each file against its SHA-256 in pin.json. As @imran-siddique asked on #469, it installs and runs nothing from the corpus repository, and a disagreement not listed in pin.json fails the job. No corpus release has these cases yet, so pin.json names a commit; when a verdict moves, I'd open a pin.json bump for you to merge. I'll fold in comments made until October 30, such as a preference to vendor the cases byte-identical, as #548 did.Type of change
Conformance tooling, with no normative effect.
Spec section
At main TR-ANC-002 agrees on 19 of 27 and pin.json lists the other eight; on #533, seven of those eight agree and print a notice.
Tests for a fix
This job's run on my fork is green.
Checklist
git commit -s)