Repository navigation
docs(harness): reattach toFilesystem javadoc in LocalFilesystemSpec - #3432
Open
zh-hanlabs wants to merge 1 commit into
Open
zh-hanlabs wants to merge 1 commit into
zh-hanlabs wants to merge 1 commit into
Conversation
|
|
Collaborator
|
请签署 CLA |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.4-SNAPSHOT (current
main)Description
The javadoc for
LocalFilesystemSpec.toFilesystem(Path, NamespaceFactory)was orphaned: it sat directly abovegetProject(), so:toFilesystem— the method it actually documents — had no javadoc, even though its@param workspace/@param localNamespaceFactorytags match that method's exact signature (and the body references{@link #project(Path)}, a member of this spec);getProject()was preceded by two stacked javadoc blocks.This PR moves the block verbatim down to
toFilesystem. Comment-only change: no wording, formatting, or behavior changes.How to test: comment-only move — no code paths touched; wording and indentation preserved, so
mvn spotless:checkoutput is unaffected. The full test suite was not re-run since no executable code changed.Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:apply(comment-only move; formatting unchanged)mvn test) — not re-run; comment-only change, no code paths touched