cssig: distinguish abstract vs default-implemented interface members - #41
Merged
Conversation
A body-less .cssig collapsed abstract and default-implemented interface members into the same virtuality, so removing a default implementation (a source/binary break for every implementer) went undetected. Preserve the distinction by emitting virtual for default implementations (and explicit abstract for static abstract members) so it survives the round trip and is compared. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cssig normalized away virtuality for all interface members, so an abstract method and one with a default implementation were indistinguishable. Removing a default implementation — which re-breaks every implementer — went undetected, contrary to breaking-change requirements.
Changes
SignatureModel.cs—FlagsFromno longer strips virtuality bits for interface members; abstract vs. default-implemented (virtual) is now part of the compared signature.CsSigWriter.cs— emitsvirtualfor default-implemented interface members and explicitabstractforstatic abstractmembers (static members aren't implicitly abstract) so signatures round-trip while preserving the distinction. Instance abstract members stay implicit.GRAMMAR.md— documents the modifier rules.InterfaceDefaultImplementationRemovalReported(virtual→abstract flagged CSSIG005); updatedRoundTripDefaultInterfaceMethodsand the static-ness test. All 63 CsSig tests pass.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com