Skip to content

Close the v2 re-audit's framework findings #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahegyes merged 15 commits into from
Oct 29, 2026
Merged

Close the v2 re-audit's framework findings #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
38a50eb
Schedule the runner's in-hook continuation a second ahead
ahegyes Oct 29, 2026
c528ae4
Enqueue a pending batched step without taking the migration lock
ahegyes Oct 29, 2026
4448c8d
Save a post meta box's form on attachments too
ahegyes Oct 29, 2026
e1a050c
Key a viewer's network notice state by network
ahegyes Oct 29, 2026
a2ca709
Offer only release tags whose suffix version_compare() orders
ahegyes Oct 29, 2026
976e842
Serialize package splits per ref and run them only for trunk and tags
ahegyes Oct 29, 2026
c1761d7
Keep the changelog directory and validate its fragments in CI
ahegyes Oct 29, 2026
c1d9579
Test that serialized-looking strings store as strings
ahegyes Oct 29, 2026
547a528
Test the logger's production threshold and the kernel's second boot
ahegyes Oct 29, 2026
091869a
Drop the unused unique flag from the scheduler backends' enqueue()
ahegyes Oct 29, 2026
dcfb7ee
Run wp-scripts from a locked devDependency
ahegyes Oct 29, 2026
ade5c62
Say that a WooCommerce settings field renders only on a custom type
ahegyes Oct 29, 2026
1321bd3
Correct the limitations and docblocks the re-audit found stale
ahegyes Oct 29, 2026
b0cadcb
Give the core persona the plugin anatomy the conventions set
ahegyes Oct 29, 2026
0a0cbf2
Move the wordpress-configs pins to its current trunk
ahegyes Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/audit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ jobs:
audit:
name: Audit
# Dev-dependency advisories surface through Dependabot alerts instead of failing this gate.
uses: ahegyes/wordpress-configs/.github/workflows/reusable-supply-chain-audit.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-supply-chain-audit.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
with:
npm-audit-flags: '--omit=dev --audit-level=high'
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ jobs:
actions: read
contents: read
security-events: write
uses: ahegyes/wordpress-configs/.github/workflows/reusable-codeql.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-codeql.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
10 changes: 5 additions & 5 deletions .github/workflows/quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ permissions:
jobs:
lint-php:
name: Lint PHP
uses: ahegyes/wordpress-configs/.github/workflows/reusable-php-lint.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-php-lint.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
with:
scripts: '["lint:php:phpcs", "lint:php:phpcs:tests", "lint:php:phpstan"]'
scripts: '["lint:php:phpcs", "lint:php:phpcs:tests", "lint:php:phpstan", "changelog:validate"]'

php-syntax:
name: PHP syntax
uses: ahegyes/wordpress-configs/.github/workflows/reusable-php-syntax-check.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-php-syntax-check.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
with:
php-versions: '["7.4"]'
paths: '["packages/bootstrap"]'
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
needs: consumer-a-build
permissions:
contents: read
uses: ahegyes/wordpress-configs/.github/workflows/reusable-plugin-check.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-plugin-check.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
with:
artifact: consumer-a
plugin-slug: acme-consumer-a
Expand All @@ -73,7 +73,7 @@ jobs:
needs: consumer-a-build
permissions:
contents: read
uses: ahegyes/wordpress-configs/.github/workflows/reusable-php-syntax-check.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-php-syntax-check.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
with:
artifact: consumer-a
php-versions: '["7.4"]'
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/split-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,16 @@ on:
permissions:
contents: read

# Splits of one ref run in order, so an older run never force-pushes over a newer split.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

jobs:
split:
name: Split ${{ matrix.package.dir }} → ${{ matrix.package.repo }}
# A dispatch from another branch would force-push that branch's split over the mirrors' trunk.
if: github.ref == 'refs/heads/trunk' || startsWith( github.ref, 'refs/tags/v' )
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ permissions:
jobs:
integration:
name: Integration
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
with:
php-version: '8.5'
wp-env-core: 'https://wordpress.org/nightly-builds/wordpress-latest.zip'
Expand All @@ -21,7 +21,7 @@ jobs:

integration-multisite:
name: Integration (multisite)
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
with:
php-version: '8.5'
wp-env-core: 'https://wordpress.org/nightly-builds/wordpress-latest.zip'
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ permissions:
jobs:
unit:
name: Unit
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
with:
php-version: '8.5'
composer-script: 'test:unit'
Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
fail-fast: false
matrix:
wp: ${{ fromJSON(needs.wordpress.outputs.versions) }}
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
with:
php-version: '8.5'
wp-version: ${{ matrix.wp }}
Expand All @@ -61,7 +61,7 @@ jobs:
fail-fast: false
matrix:
wp: ${{ fromJSON(needs.wordpress.outputs.versions) }}
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
with:
php-version: '8.5'
wp-version: ${{ matrix.wp }}
Expand All @@ -70,15 +70,15 @@ jobs:

integration-php74:
name: Integration (PHP 7.4)
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
with:
php-version: '8.5'
composer-script: 'test:integration:php74:run'
wp-env-config-file: '.wp-env.php74.json'

prefer-lowest:
name: Prefer lowest
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
with:
php-version: '8.5'
composer-script: 'test:integration:lowest:run'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/workflow-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ jobs:
contents: read
security-events: write
actions: read
uses: ahegyes/wordpress-configs/.github/workflows/reusable-workflow-checks.yml@88710a71e2bcc7db7cb81b4eb96411438369ce0f
uses: ahegyes/wordpress-configs/.github/workflows/reusable-workflow-checks.yml@3cbd985255e76f8026644ccdee5be0b2b2da312b
Loading
Loading