Repository navigation
Name the main file in uninstall.php and move the configs pins - #24
Merged
Merged
Conversation
The npm lock trailed in-range patch releases: puppeteer-core 25.16.0, webpack 5.112.1, sass 1.106.1, web-features 3.44.0 and 15 more move up, and none moves down under the host's seven-day release-age cooldown. path-to-regexp and react-is only swap which copy sits at the top of node_modules. The production npm audit stays clean. Composer has no update beyond wordpress-configs, which the next commit moves with the configs pins. Assisted-by: Claude Code:claude-opus-5-5
The template pinned wordpress-configs at f420c38, whose release took the main plugin file from an entry-file input and could ship it under another name through archive-entry-file, and the wordpress.org recipe told a plugin keeping a 1.x bootstrap.php to pass that input. The wordpress.org zips of the plugins that recipe served ship <slug>.php, so no plugin needs the rename, and configs 8d53efd drops both inputs: its release takes the main file to be the root PHP file with a Plugin Name header, as WordPress does. The 13 workflow refs, package.json's git dependency and both locks move to configs 8d53efd, and the recipe's step for archive-entry-file goes. Each lock changes only the configs entry. Assisted-by: Claude Code:claude-opus-5-5
The uninstall row hid the main file and wrote a floored copy as bootstrap.php, because a release could ship the main file under another name. configs' release no longer renames it, so the row floors the main file in place and keeps WP_UNINSTALL_PLUGIN naming another plugin, as a bulk uninstall leaves it, and still expects the below-floor log line. It passes before and after the next commit, which names the main file in uninstall.php again; a removal has no new behaviour to fail first. Assisted-by: Claude Code:claude-opus-5-5
uninstall.php found the main file by scanning its folder for the one PHP file with a Plugin Name header, because a release could ship the main file under another name than the source's. configs' release no longer renames it, so the scan guarded a case that cannot arise. uninstall.php names dws-plugin-template.php again, which the fill-in renames to the plugin's slug along with the file itself. Assisted-by: Claude Code:claude-opus-5-5
ahegyes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wordpress-configs' release no longer renames the main plugin file, so the template moves its configs pins to that release, drops the wordpress.org recipe's
archive-entry-filestep, and names its main file inuninstall.phpinstead of scanning for the plugin header.Type of change
Checklist
composer changelog:add)composer quality-checkpasses locallyBreaking changes for forks
The pinned configs release declares neither
entry-filenorarchive-entry-file, so a generated plugin whoserelease.ymlpasses either drops it; the release finds the main file as WordPress does. A generated plugin'suninstall.phpnames<slug>.php, which the fill-in writes.