Repository navigation
Test the underscore include skip in Internal Comments and Linked Orders - #25
Merged
Merged
Conversation
The boot row asserted that includes/_disabled-example.php never loads, but no such file exists, so the row passed even with the loader's underscore check removed. The row writes an underscore-prefixed include defining a constant and checks in a fresh request, which must exit cleanly, that the plugin booted and the constant stayed undefined; it fails once the loader's check is removed. The fresh request comes from RunsRequestsTrait in tests/Support, which PartialDeployTest's helper moves to. Assisted-by: Claude Code:claude-opus-5-5
The row read "skipped" from a fresh request whenever the constant the underscore include defines stayed undefined, which also happens when the plugin never loads or boots in that request or the include was never written, so the row could pass without testing the loader. The row checks the write and prints "not booted" unless the plugin's boot succeeded, through RunsRequestsTrait in tests/Support, which PartialDeployTest's helper moves to; the request's exit status is still checked. Assisted-by: Claude Code:claude-opus-5-5
ahegyes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Internal Comments' boot row asserted that
includes/_disabled-example.phpnever loads, but the file does not exist, so the row passed with the loader's underscore check removed; it now writes its own underscore include, as Linked Orders' row does. Both rows check, in a fresh request that exits cleanly, that the plugin booted and the include stayed unloaded, throughRunsRequestsTrait, which moves from eachPartialDeployTesttotests/Support/. Test-only; it merges cleanly with #24.Type of change
Checklist
composer changelog:addin the changed plugin's directory, or at the root for the monorepo itself) (test-only)composer quality-checkpasses locally in every changed pluginreadme.txtupdated if runtime requirements changed (unchanged)