Repository navigation
fix(neuron): Wan and HunyuanVideo 1.0 DiTs get the scheduler timestep in fp32 - #156
Merged
Merged
Conversation
… in fp32, as diffusers passes it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diffusers passes the scheduler timestep to these DiTs unrounded (fp32); the native path cast it to bf16 with the other inputs. bf16 holds only multiples of 4 between 512 and 1024 (and of 2 between 256 and 512), which shifts the sinusoidal timestep embedding at every step. Same fix as LTX-2's (#142).
Change
timestep_dtype = torch.float32and send the timestep to the device in fp32; the other inputs keep the model dtype, in the module's argument order.Verification
trn3.48xlarge, one chip, TP4, same prompt, seed 42 and 50 steps as the quality evaluation, against diffusers fp32 on GPU (mean / worst frame):
The before numbers reproduce the quality evaluation's. HunyuanVideo 1.0 and Wan 2.1 improve on every metric; Wan 2.2 improves in mean PSNR with a lower worst-frame SSIM, within single-prompt sensitivity. Unit tests updated for the fp32 warm-up timestep and contracts.