Skip to content

chore: remove is node initialized check - #245

Merged
domire8 merged 3 commits into
feat/tffrom
revert/get-node
Apr 8, 2026
Merged

domire8 merged 3 commits into
feat/tffrom
revert/get-node

Conversation

@domire8

@domire8 domire8 commented Apr 7, 2026 •

Copy link
Copy Markdown

Description

With #173, we introduced a helper is_node_initialized in the controller interface. However, it was not consistently used and also doesn't bring any benefit since it was just catching the runtime error from here and rethrowing with a different error. If anything, we would have to do that on each get_node() (and there are many of those) so I'm in favor of not doing that at all. Anyways, such problems would only arise if someone was do to something weird in a constructor of a controller.

I also ran a few tests, we never run into segfaults with get_node() which I was initially afraid of.

Review guidelines

Estimated Time of Review: 5 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

Related issues

Blocks:

@domire8
domire8 requested review from SprGrf and yrh012 April 7, 2026 07:51
@domire8
domire8 requested a review from eeberhard as a code owner April 7, 2026 07:51

@eeberhard eeberhard left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will need a breaking changelog entry before going into main

edit: I see it was only introduced in the base branch anyway, never mind

@domire8
domire8 merged commit 260d06e into feat/tf Apr 8, 2026
3 of 4 checks passed
@domire8
domire8 deleted the revert/get-node branch April 8, 2026 10:30
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants