Skip to content

feat(controllers): use parent node for tf listener (#190) - #247

Merged
domire8 merged 2 commits into
mainfrom
feat/parent-node
Apr 16, 2026
Merged

domire8 merged 2 commits into
mainfrom
feat/parent-node

Conversation

@domire8

@domire8 domire8 commented Apr 14, 2026 •

Copy link
Copy Markdown

Description

Another PR to fast forward from the breaking branch. I should have included this in the previous one already..

Review guidelines

Estimated Time of Review: 3 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8
domire8 requested review from SprGrf and yrh012 April 14, 2026 10:02
@domire8
domire8 requested a review from eeberhard as a code owner April 14, 2026 10:02
@domire8

domire8 commented Apr 14, 2026

Copy link
Copy Markdown
Author

We do the same thing for the modulo components since a long time btw so this is a no brainer

this->tf_listener_ = std::make_shared<tf2_ros::TransformListener>(

@domire8
domire8 merged commit ebb6571 into main Apr 16, 2026
4 checks passed
@domire8
domire8 deleted the feat/parent-node branch April 16, 2026 15:47
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants