Skip to content

fix(controllers): resolve parameter validation todos - #248

Merged
domire8 merged 3 commits into
mainfrom
fix/activation-timemout
Apr 14, 2026
Merged

domire8 merged 3 commits into
mainfrom
fix/activation-timemout

Conversation

@domire8

@domire8 domire8 commented Apr 14, 2026 •

Copy link
Copy Markdown

Description

This PR takes a commit from breaking branch and applies it to main. Since it concerns parameter validation, I also resolved the TODOs.

Review guidelines

Estimated Time of Review: 5 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8
domire8 requested a review from eeberhard as a code owner April 14, 2026 11:25
@domire8 domire8 changed the title Fix/activation timemout fix(controllers): resolve parameter validation todos Apr 14, 2026
Comment thread CHANGELOG.md Outdated
Co-authored-by: Dominic Reber <71256590+domire8@users.noreply.github.com>
@domire8
domire8 requested review from SprGrf and yrh012 April 14, 2026 11:26
@domire8

domire8 commented Apr 14, 2026 •

Copy link
Copy Markdown
Author

related but not blocking

ros-controls/ros2_control#3220

@yrh012 yrh012 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@domire8
domire8 merged commit 1222c90 into main Apr 14, 2026
4 checks passed
@domire8
domire8 deleted the fix/activation-timemout branch April 14, 2026 12:49
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 14, 2026
Comment thread source/modulo_controllers/src/ControllerInterface.cpp
Comment thread source/modulo_controllers/src/RobotControllerInterface.cpp
@SprGrf

SprGrf commented Apr 14, 2026

Copy link
Copy Markdown

My bad, missed it. Minor nits anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants